feat: upgrade linux-tools-mac to latest toolsets#168
Merged
Conversation
…kedepend, glib, libgsf, libtool, pcre, gettext
There was a problem hiding this comment.
Pull request overview
This PR adds an automated build system and CI workflow to produce a portable macOS bundle of GNU/Linux-related tooling (linux-tools) used by electron-builder when packaging Linux targets on macOS.
Changes:
- Add
packages/linux-tools/assets/build-mac.shto install Homebrew formulas, collect binaries + dylib deps, patch install names, codesign, and archive the resulting bundle. - Add
packages/linux-tools/build.shwrapper plus a new GitHub Actions workflow to build and upload the bundle for both Intel and Apple Silicon runners. - Add a changeset marking a major release for
linux-tools, and enrichlinux-toolspackage metadata with a description.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| packages/linux-tools/package.json | Adds a package description clarifying the purpose/contents of linux-tools. |
| packages/linux-tools/build.sh | New wrapper script that runs the macOS bundle build and writes output to a standard out/ directory. |
| packages/linux-tools/assets/build-mac.sh | Core build script: installs dependencies, collects binaries/libs, patches dylib paths, signs, verifies, and creates an archive. |
| .github/workflows/build.yaml | Wires linux-tools into the main “Build artifacts” workflow matrix. |
| .github/workflows/build-linux-tools.yaml | New reusable workflow to build linux-tools on macOS Intel + ARM runners and upload the archive artifact. |
| .changeset/eleven-ghosts-bow.md | Declares a major linux-tools release corresponding to the tooling upgrade/build system change. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
mmaietta
changed the title
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces a new workflow and build system for producing a portable macOS bundle of GNU/Linux-compatible tools, which are used when packaging Linux targets on macOS. The changes include a major version bump for the
linux-toolspackage, a new GitHub Actions workflow for building the bundle, and robust scripts to automate the collection, patching, and packaging of required binaries and their dependencies.Key changes:
Build System & Automation
build-mac.sh) that automates the installation, collection, license gathering, dependency patching, code-signing, and packaging of GNU/Linux-compatible tools for macOS, ensuring all binaries and libraries are portable and self-contained.build.sh) to orchestrate the build process and output the resulting bundle to a standardized directory.